zhengxiang378928908-code commented on PR #18361: URL: https://github.com/apache/iceberg/pull/18361#issuecomment-6566765358
Thanks for adding these. Two things on `cf33b01a9`: 1. The four delete tests check `table.newScan().planFiles()` with `doesNotThrowAnyException()`, but `planFiles()` is lazy. `ManifestGroup.plan()` builds the `DeleteFileIndex` right away, but data manifests are only read when the iterable is consumed, so the step that matches deletes to data files by partition value never runs. The failure we care about here is a delete that silently stops applying, which won't throw. Could you iterate the tasks and assert on them? For example, filter on `region = 5L` and check the expected task count and `task.deletes().size()` (one task with one delete in the before/after cases). My earlier probe used that check. 2. The merge with main brought back `CVE-2026-68494` in `.github/trivyignore/kafka-connect-runtime.trivyignore.yaml`. Main dropped that entry after the Parquet 1.18.1 bump, so it looks like a leftover from conflict resolution. Could you remove it from this PR? The `ManifestWriter` / `PartitionData` changes look good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
