mikepapadim commented on PR #18631: URL: https://github.com/apache/iceberg/pull/18631#issuecomment-6398104213
Thanks for the review! Good point: with `copy` now carrying the equality field IDs, both the `ofEqualityDeletes(...)` before `copy(file)` and the `withSplitOffsets(...)` in `RewriteTablePathUtil.newEqualityDeleteEntry` are redundant, so I dropped them in this PR. `TestRewriteTablePathsAction` covers that path with equality deletes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
