dramaticlly commented on code in PR #18631:
URL: https://github.com/apache/iceberg/pull/18631#discussion_r4416099103
##########
core/src/main/java/org/apache/iceberg/FileMetadata.java:
##########
@@ -98,6 +99,10 @@ public Builder copy(DeleteFile toCopy) {
this.partitionData = DataFiles.copyPartitionData(spec,
toCopy.partition(), partitionData);
}
this.content = toCopy.content();
+ this.equalityFieldIds =
Review Comment:
fix looks right, worth calling out anything existing caller with
`ofEqualityDeletes(ids).copy(src)` will now have ids silently discarded, like
in core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java.
spot checked the known caller within repo it seems fine, but copy on
FileMetadata is a public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
