romusz commented on code in PR #3295:
URL: https://github.com/apache/iceberg-rust/pull/3295#discussion_r4372146437
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -254,6 +267,22 @@ impl RestCatalogConfig {
self.props.get("oauth2-server-uri").cloned()
}
+ /// Parse only the effective value, after server defaults and overrides
are merged.
+ fn page_size(&self) -> Result<Option<NonZeroU32>> {
+ self.props
+ .get(REST_CATALOG_PROP_PAGE_SIZE)
+ .map(|value| {
+ value.parse::<NonZeroU32>().map_err(|err| {
Review Comment:
done in
[64c53a6](https://github.com/apache/iceberg-rust/pull/3295/commits/64c53a6e94c467525ee88ba55c5f2e2a79fcc65a)
thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
