manuzhang commented on code in PR #17562:
URL: https://github.com/apache/iceberg/pull/17562#discussion_r4379002870
##########
spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java:
##########
@@ -88,7 +89,9 @@ class BatchDataReader extends BaseBatchReader<FileScanTask>
@Override
public CustomTaskMetric[] currentMetricsValues() {
return new CustomTaskMetric[] {
- new TaskNumSplits(numSplits), new TaskNumDeletes(counter().get())
+ new TaskNumSplits(numSplits),
Review Comment:
Since the no-op `initMEtricsValues` is inherited, metrics from a later
reader will override that of a previous one in the same task. Could you please
fix it in a follow-up PR? Same for RowDataReader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
