venkata91 commented on code in PR #17562: URL: https://github.com/apache/iceberg/pull/17562#discussion_r4404996187
########## spark/v4.1/spark/src/test/java/org/apache/iceberg/spark/source/metrics/TestScanDuration.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.source.metrics; + +import static org.assertj.core.api.Assertions.assertThat; + +import java.util.Locale; +import org.junit.jupiter.api.Test; + +public class TestScanDuration { + + @Test + public void testAggregateTaskMetrics() { Review Comment: Done in 51ae7428d. I also dropped the prefix from the two tests this PR adds to `TestSparkReadMetrics`, and made `TestScanDuration` package-private. Thanks for the review! I'll open the Spark 4.2 port once this merges. ########## spark/v4.1/spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java: ########## @@ -88,7 +89,9 @@ class BatchDataReader extends BaseBatchReader<FileScanTask> @Override public CustomTaskMetric[] currentMetricsValues() { return new CustomTaskMetric[] { - new TaskNumSplits(numSplits), new TaskNumDeletes(counter().get()) + new TaskNumSplits(numSplits), Review Comment: Good catch. With the no-op inherited, a later reader in the same task starts from zero instead of picking up the earlier reader's value, so only the last reader's duration survives. I'll fix `BatchDataReader` and `RowDataReader` together in a follow-up and link it here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
