kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r563401055
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java
##########
@@ -372,6 +372,38 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
return ROWS_MIGHT_MATCH;
}
+ @Override
+ public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
Review comment:
I'm going to mark this as closed to make it easier for people to review
this. As discused in a comment elsewhere with @rdblue and @RussellSpitzer,
places where substitution of `notStartsWith`'s definition as `!startsWith` have
been updated. The remaining ones require the usage of a `notStartsWith`
specific definition due to the above contraints in regards to what is being
tested for (i.e. we're testing in those cases for `file might match`).
If anybody has any concerns feel free to comment here or elsewhere 👍
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/InclusiveMetricsEvaluator.java
##########
@@ -372,6 +372,38 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
return ROWS_MIGHT_MATCH;
}
+ @Override
+ public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
Review comment:
I'm going to mark this conversation as resolved to make it easier for
people to review this. As discused in a comment elsewhere with @rdblue and
@RussellSpitzer, places where substitution of `notStartsWith`'s definition as
`!startsWith` have been updated. The remaining ones require the usage of a
`notStartsWith` specific definition due to the above contraints in regards to
what is being tested for (i.e. we're testing in those cases for `file might
match`).
If anybody has any concerns feel free to comment here or elsewhere 👍
##########
File path: site/docs/api.md
##########
@@ -172,6 +172,7 @@ Supported predicate expressions are:
* `in`
* `notIn`
* `startsWith`
+* `notStartsWith`
Review comment:
Marking this as resolved to make this easier to review as this is not a
concern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
