[GitHub] [iceberg] rdblue commented on a change in pull request #2062: [CORE] Add in a NOT_STARTS_WITH operator with filter pushdown

[GitBox]

rdblue commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r567170424



##########
File path: api/src/main/java/org/apache/iceberg/transforms/ProjectionUtil.java
##########
@@ -197,6 +197,8 @@ private ProjectionUtil() {
         return predicate(Expression.Operation.EQ, name, 
transform.apply(boundary));
       case STARTS_WITH:
         return predicate(Expression.Operation.STARTS_WITH, name, 
transform.apply(boundary));
+      case NOT_STARTS_WITH:
+        return predicate(Expression.Operation.NOT_STARTS_WITH, name, 
transform.apply(boundary));

Review comment:
       Actually, from looking at the handling in `Truncate`, I think we can 
handle this without using the `truncateArray` methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org