kevinjqliu commented on code in PR #3561:
URL: https://github.com/apache/iceberg-rust/pull/3561#discussion_r4395252537
##########
.github/actions/generate-python-license/action.yml:
##########
@@ -21,6 +21,7 @@ runs:
using: "composite"
steps:
- name: Install cargo-about
+ # Keep version in sync with the install-cargo-about target in
bindings/python/Makefile.
uses: taiki-e/install-action@4cef1412cce204788f482e778a0b9187f9626a29 #
v2.87.21
with:
tool: [email protected]
Review Comment:
same as version in `bindings/python/Makefile`
##########
dev/release/create_rc.sh:
##########
@@ -307,8 +307,9 @@ check_rc_tag_available() {
}
check_dependency_licenses() {
+ require_command make
require_command python3
- python3 "${SCRIPT_DIR}/licenses.py" dependencies check
+ make -C "${REPO_ROOT}" check-dependency-licenses
Review Comment:
similar change, but for `make check-dependency-licenses`
Replace `python3 dev/release/licenses.py dependencies check` calls with
`make check-dependency-licenses`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
