kevinjqliu opened a new pull request, #3561: URL: https://github.com/apache/iceberg-rust/pull/3561
## Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> - N/A ## What changes are included in this PR? <!-- Provide a summary of the modifications in this PR. List the main changes such as new features, bug fixes, refactoring, or any other updates. --> CI pins versions for these two tools, but the local commands for these two workflows used whatever version was already installed. That's a footgun: the local result can differ from CI's without any warning. This PR routes both through make targets that install CI's version first: - **pyiceberg-core LICENSE check** (`bindings/python/LICENSING.md`): `make -s cargo-about` installs cargo-about 0.9.2. - **Release dependency license check** (`create_rc.sh` and the release docs): `make check-dependency-licenses` installs cargo-deny 0.19.9. Example: while working on #3558, local cargo-about 0.9.1 left out zstd-sys's vendored `zstd/LICENSE` and `LICENSE.BSD-3-Clause`, but CI's 0.9.2 includes them ([cargo-about 0.9.2 changelog](https://github.com/EmbarkStudios/cargo-about/blob/main/CHANGELOG.md)). So the local run pointed to a different conclusion about the zstd-sys clarification than CI. ## Are these changes tested? <!-- Specify what test covers (unit test, integration test, etc.). If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> Manually: - `make -s cargo-about` (in `bindings/python`): passed. It replaced a local 0.9.1 with 0.9.2, its output was byte-identical to a standalone 0.9.2 run, and it found no placeholder matches. - `dev/release/create_rc.sh 0.0.1 1 --create_rc_tag 0 --check_headers 0 --check_publish 0 --sign 0 --upload_svn 0 --dist_dir /tmp/ice-rc-test`: passed. The dependency license step used cargo-deny 0.19.9 and printed `licenses ok`. ## AI Disclosure <!-- https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions --> Written with GitHub Copilot. Two side effects worth a look, both following the existing `install-<tool>` targets: `make install-cargo-*` replaces any other globally installed version, and `create_rc.sh` now needs `make` and may compile cargo-deny on its first run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
