rymurr commented on a change in pull request #2146:
URL: https://github.com/apache/iceberg/pull/2146#discussion_r564262364
##########
File path: core/src/test/java/org/apache/iceberg/TestCatalogUtil.java
##########
@@ -87,6 +87,32 @@ public void loadCustomCatalog_NotImplementCatalog() {
() -> CatalogUtil.loadCatalog(TestCatalogNoInterface.class.getName(),
name, options, hadoopConf));
}
+ @Test
+ public void loadCustomCatalog_ConstructorErrorCatalog() {
+ Map<String, String> options = new HashMap<>();
+ options.put("key", "val");
+ Configuration hadoopConf = new Configuration();
+ String name = "custom";
+
+ String impl = TestCatalogErrorConstructor.class.getName();
+ AssertHelpers.assertThrows("must be able to initialize catalog",
Review comment:
all the other tests use this format 'must be able to', 'must have' etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
