rdblue commented on a change in pull request #2146:
URL: https://github.com/apache/iceberg/pull/2146#discussion_r564745063
##########
File path: common/src/main/java/org/apache/iceberg/common/DynConstructors.java
##########
@@ -235,6 +236,10 @@ public Builder hiddenImpl(String className, Class<?>...
types) {
throw new RuntimeException("Cannot find constructor for " +
baseClass + "\n" + formatProblems(problems));
}
+
+ public Map<String, Throwable> problems() {
+ return ImmutableMap.copyOf(problems);
+ }
Review comment:
Why does this need to be public? The problems are already added when
exceptions are thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]