binarybrain-009 opened a new pull request, #18692: URL: https://github.com/apache/iceberg/pull/18692
`HiveViewOperations.doCommit` throws `CommitFailedException` as soon as HMS reports "The table has been modified", even when the alter was applied and the client only saw the error on a retry. The finally block then deletes the new metadata file that HMS already points to. This mirrors `HiveTableOperations.doCommit` (#12637): on that message the view commit now runs `checkCommitStatusStrict` and fails only if the new metadata location is not current; other errors keep the non-strict check. This refreshes the stale #17087 by @thswlsqls. Closes #17074 Test plan: a new `TestHiveViewCommits` test persists the commit, then throws the "modified" error, and asserts the commit succeeds with the new metadata location current; it fails with `CommitFailedException` without the fix, and the existing no-lock test still covers a real conflict. `:iceberg-hive-metastore:test`, checkstyle and spotless pass. --- **AI Disclosure** - Model: Claude Opus 5.5 - Platform/Tool: Claude Code - Human Oversight: fully reviewed - Prompt Summary: Fix apache/iceberg#17074 (Hive view commits fail on the HMS "modified" error without checking commit status); the fix and its tests are generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
