binarybrain-009 opened a new pull request, #18693: URL: https://github.com/apache/iceberg/pull/18693
`AssumeRoleAwsClientFactory.s3()` skips `applyS3AccessGrantsConfigurations` and `applyUserAgentConfigurations`, so S3 clients built through the assume-role factory ignore `s3.access-grants.enabled` and lack the `s3fileio/` user agent prefix that `DefaultAwsClientFactory.s3()` sets. This applies both at the same position as the default factory, between the signer and retry configurations. `LakeFormationAwsClientFactory` inherits the fix for tables not registered with Lake Formation; its registered-table branch builds its own client with vended credentials and is left unchanged. This refreshes the stale #17246 by @thswlsqls. Closes #17245 Test plan: new `TestAwsClientFactories` tests build the assume-role S3 client and assert that enabling access grants installs the access grants credentials provider, and that the client carries the `s3fileio/` user agent prefix; both fail without the fix. --- **AI Disclosure** - Model: Claude Opus 5.5 - Platform/Tool: Claude Code - Human Oversight: fully reviewed - Prompt Summary: Fix apache/iceberg#17245 (AssumeRoleAwsClientFactory.s3() skips S3 access grants and user agent configuration); the fix and its tests are generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
