binarybrain-009 opened a new pull request, #18694: URL: https://github.com/apache/iceberg/pull/18694
`JdbcClientPool` passes every `jdbc.`-prefixed catalog property to the JDBC driver, including the catalog's own `jdbc.strict-mode`, `jdbc.schema-version`, `jdbc.init-catalog-tables` and `jdbc.metadata-refresh-max-retries`, so drivers that reject unknown connection properties fail to connect. This excludes those keys from the driver properties; every other `jdbc.` property, including the ones `SnowflakeCatalog` sets for its driver, is still passed through. `filterAndRemovePrefix` becomes `driverProperties` because its only caller always used the `jdbc.` prefix. This refreshes the stale #13673 by @patricklucas and also covers `metadata-refresh-max-retries`, which was added since. Closes #13672 Test plan: A new `TestJdbcUtil` case checks that the four catalog properties are dropped while other `jdbc.` properties are kept; it fails without the fix. All `org.apache.iceberg.jdbc` tests in core pass. --- **AI Disclosure** - Model: Claude Opus 5.5 - Platform/Tool: Claude Code - Human Oversight: fully reviewed - Prompt Summary: Fix #13672 so Iceberg's own JDBC catalog properties are not passed to the JDBC driver; the fix and its tests are generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
