mxm commented on code in PR #18525:
URL: https://github.com/apache/iceberg/pull/18525#discussion_r4426363745
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordInternalType.java:
##########
@@ -71,7 +76,8 @@ public boolean isKeyType() {
@Override
public TypeSerializer<DynamicRecordInternal>
createSerializer(SerializerConfig serializerConfig) {
return new DynamicRecordInternalSerializer(
- new TableSerializerCache(catalogLoader, cacheSize),
writeSchemaAndSpec);
+ new TableSerializerCache(catalogLoader, cacheSize,
inputSchemasPerTableCacheMaximumSize),
Review Comment:
Could we add a test that creates `DynamicRecordInternalType` with
non-default sizes, e.g. 5 and 3, and checks both sizes on the cache? The two
`int` arguments are easy to mix up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
