wombatu-kun commented on code in PR #16602:
URL: https://github.com/apache/iceberg/pull/16602#discussion_r4431196878
##########
kafka-connect/kafka-connect-transforms/src/main/java/org/apache/iceberg/connect/transforms/KafkaMetadataTransform.java:
##########
@@ -97,7 +97,7 @@ public void addToMap(SinkRecord record, Map<String, Object>
map) {
private static final String KEY_METADATA_FIELD_NAME = "field_name";
private static final String KEY_METADATA_IS_NESTED = "nested";
private static final String DEFAULT_METADATA_FIELD_NAME = "_kafka_metadata";
- private static RecordAppender recordAppender;
+ private RecordAppender recordAppender;
Review Comment:
No, it came out of reading the module, not from a user report.
The case for merging it anyway: the settings in effect are those of
whichever task using the SMT started last on that worker, so each connector's
tables can receive records in either connector's metadata layout (field names,
nested or flat), and the layout can switch when a task restarts or a rebalance
moves one. Where every instance shares one config the output is identical
before and after, so the fix only changes setups whose output is wrong today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
