rambleraptor commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4447957305
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -753,6 +849,15 @@ public T variant(Types.VariantType variant) {
throw new UnsupportedOperationException("Unsupported type: variant");
}
+ /**
+ * Handles a file type, by default as the struct of its nested fields.
+ *
+ * <p>Override this to distinguish a file from a struct.
+ */
+ public T file(Types.FileType file, List<T> fieldResults) {
Review Comment:
It looks like this has been overridden everywhere except PruneColumns, which
means that PruneColumns is treating FILEs as structs.
Would we not want to project all of the columns of a File type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
