JeonDaehong commented on code in PR #3508:
URL: https://github.com/apache/iceberg-rust/pull/3508#discussion_r4443137172
##########
crates/iceberg/src/arrow/reader/predicate_visitor.rs:
##########
@@ -249,6 +251,20 @@ impl PredicateConverter<'_> {
Ok(constant_bool_array(false, batch.num_rows()))
}))
}
+
+ fn missing_field_is_null(&self, reference: &BoundReference) -> bool {
Review Comment:
`not_in` and `not_starts_with` still return `build_always_true()` for a
missing nullable column. On this branch `b NOT IN ('x', 'y')` and `b NOT STARTS
WITH 'x'` give 3 rows when `b` is missing from the file and 0 when it's stored
as NULL. Same mismatch as `<`, so maybe worth covering here, or a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
