JeonDaehong commented on code in PR #3508:
URL: https://github.com/apache/iceberg-rust/pull/3508#discussion_r4467099972
##########
crates/iceberg/src/arrow/reader/predicate_visitor.rs:
##########
@@ -249,6 +251,20 @@ impl PredicateConverter<'_> {
Ok(constant_bool_array(false, batch.num_rows()))
}))
}
+
+ fn missing_field_is_null(&self, reference: &BoundReference) -> bool {
Review Comment:
Re-ran my probe on 90649d66. `NOT IN` and `NOT STARTS WITH` now give 0 rows
for the missing column, same as the stored-NULL file. `NOT (b < 'm')`, `IS
NULL` and `IS NOT NULL` match too. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
