danielcweeks commented on code in PR #17545: URL: https://github.com/apache/iceberg/pull/17545#discussion_r4445527675
########## api/src/main/java/org/apache/iceberg/FileWithEncryptedKey.java: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import org.apache.iceberg.encryption.EncryptedKey; + +/** + * A file that may be encrypted using an {@link EncryptedKey}. + * + * <p>The encrypted key is either referenced by its ID from the table metadata encryption keys, or + * stored directly with the file's metadata that describe the file. If neither is present, the file + * is not encrypted. + */ +public interface FileWithEncryptedKey { Review Comment: I'd prefer that we use something like `EncryptedFile`. We shouldn't name based on what it contains, but rather what it represents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
