danielcweeks commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r4445627009
##########
api/src/main/java/org/apache/iceberg/io/FileIO.java:
##########
@@ -71,6 +72,11 @@ default InputFile newInputFile(ManifestFile manifest) {
return newInputFile(manifest.path(), manifest.length());
}
+ /**
+ * @deprecated since 1.13.0, will be removed in 2.0.0; use {@link
+ * #newInputFile(FileWithEncryptedKey)} instead.
+ */
+ @Deprecated
default InputFile newInputFile(ManifestListFile manifestList) {
Review Comment:
Rather than deprecating each of these, we could update all of the exiting
`*File` types to implement `EncryptedFile` which would then have a common way
to reference the necessary fields without having to update all of the places
where they are used with FileIO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
