aokolnychyi commented on a change in pull request #2165:
URL: https://github.com/apache/iceberg/pull/2165#discussion_r565739778
##########
File path:
spark3-extensions/src/main/antlr/org.apache.spark.sql.catalyst.parser.extensions/IcebergSqlExtensions.g4
##########
@@ -69,7 +69,18 @@ statement
: CALL multipartIdentifier '(' (callArgument (',' callArgument)*)? ')'
#call
| ALTER TABLE multipartIdentifier ADD PARTITION FIELD transform (AS
name=identifier)? #addPartitionField
| ALTER TABLE multipartIdentifier DROP PARTITION FIELD transform
#dropPartitionField
- | ALTER TABLE multipartIdentifier WRITE ORDERED BY order
#setTableOrder
+ | ALTER TABLE multipartIdentifier WRITE
+ writeDistributionSpec?
Review comment:
I was interpreting DISTRIBUTED BY as a stronger clause. For example,
WRITE DISTRIBUTED BY ... ORDERED BY ... is going to be translated into a
clustered distribution. And since we first satisfy the required distribution,
it felt natural to me. However, `WRITE DISTRIBUTED BY UNORDERED` does seem a
bit weird.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
