rdblue commented on a change in pull request #2165:
URL: https://github.com/apache/iceberg/pull/2165#discussion_r566258120
##########
File path:
spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/SetWriteDistributionAndOrdering.scala
##########
@@ -19,22 +19,26 @@
package org.apache.spark.sql.catalyst.plans.logical
+import org.apache.iceberg.DistributionMode
import org.apache.iceberg.NullOrder
import org.apache.iceberg.SortDirection
import org.apache.iceberg.expressions.Term
import org.apache.spark.sql.catalyst.expressions.Attribute
+import org.apache.spark.sql.connector.catalog.CatalogV2Implicits
-case class SetWriteOrder(
- table: Seq[String],
- sortOrder: Array[(Term, SortDirection, NullOrder)]) extends Command {
- import org.apache.spark.sql.connector.catalog.CatalogV2Implicits._
+case class SetWriteDistributionAndOrdering(
Review comment:
Looks like there are extra changes to this that aren't really necessary,
like renaming `sortOrder` to `ordering` and `table` to `tableName`. Not a big
deal, but it is good in general to minimize changes that can lead to conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
