gaborkaszab commented on code in PR #18503:
URL: https://github.com/apache/iceberg/pull/18503#discussion_r4452539071
##########
format/spec.md:
##########
@@ -1241,7 +1241,7 @@ A snapshot consists of the following fields:
| _optional_ | _optional_ | _optional_ | **`schema-id`** | ID
of the table's current schema when the snapshot was created |
| | | _required_ | **`first-row-id`** |
The first `_row_id` assigned to the first row in the first data file in the
first manifest, see [Row Lineage](#row-lineage) |
| | | _required_ | **`added-rows`** |
The upper bound of the number of rows with assigned row IDs, see [Row
Lineage](#row-lineage) |
- | | | _optional_ | **`key-id`** | ID
of the encryption key that encrypts the manifest list key metadata |
+ | | | _optional_ | **`key-id`** | ID
of the encryption key that encrypts the manifest list |
Review Comment:
I think the description is incorrect in the current version. I found this
when rewriting the same description for the V4 tab (manifest list -> root
manifest), but figured we can do the same fix for V3 with this same PR. Since
we'll vote on this anyway, seems an overkill to move that fix to a separate one.
WDYT @RussellSpitzer ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
