gaborkaszab commented on code in PR #18503: URL: https://github.com/apache/iceberg/pull/18503#discussion_r4452520084
########## format/spec.md: ########## @@ -1269,6 +1271,8 @@ The snapshot summary's `operation` field is used by some operations, like snapsh For other optional snapshot summary fields, see [Appendix F](#optional-snapshot-summary-fields). +A snapshot's `key-id` and `encryption-key` fields are mutually exclusive and both must not be present. When committed while the table is at version 4 or higher, writers must store the snapshot's encryption key in `encryption-key`. Review Comment: I relaxed this to be more permissive for the writers. I don't think the encryption spec should focus on snapshot fields in the table spec, it rather should contain information on how to decrypt files using encryption keys. With that in mind I still left some explanation here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
