szlta commented on code in PR #17155:
URL: https://github.com/apache/iceberg/pull/17155#discussion_r4455864211


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4160,6 +4169,45 @@ components:
           type: string
           const: "sha-256-query-local"
 
+    KeyManagementCredential:
+      type: object
+      description: |
+        Provider-specific credential config for accessing one or more KMS keys 
required by an encrypted
+        table operation.
+
+        The key-management provider is advertised in catalog configuration, 
such as `encryption.kms-type`
+        returned from `/v1/config`. The `config` map contains 
provider-specific properties for the
+        selected key-management provider.
+
+        Catalogs that return `key-management-credentials` must include 
credentials for all KMS keys required
+        by the operation. Clients should select credentials by matching the 
IDs of KMS keys used to wrap

Review Comment:
   The intent here is to require *complete* credential coverage for the KMS 
keys needed by the operation.
   
   Yeah a client may fail if some credentials are missing, but I’d still keep 
this as an explicit catalog-side requirement so an incomplete delegated 
credential set is clearly not a valid response.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to