szlta commented on code in PR #17155:
URL: https://github.com/apache/iceberg/pull/17155#discussion_r4455877486
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -4160,6 +4169,45 @@ components:
type: string
const: "sha-256-query-local"
+ KeyManagementCredential:
+ type: object
+ description: |
+ Provider-specific credential config for accessing one or more KMS keys
required by an encrypted
+ table operation.
+
+ The key-management provider is advertised in catalog configuration,
such as `encryption.kms-type`
+ returned from `/v1/config`. The `config` map contains
provider-specific properties for the
+ selected key-management provider.
+
+ Catalogs that return `key-management-credentials` must include
credentials for all KMS keys required
+ by the operation. Clients should select credentials by matching the
IDs of KMS keys used to wrap
+ or unwrap table key encryption keys (KEKs) against `kms-key-ids`.
+
+ These IDs may be specified by the `encryption.key-id` table property
or recorded in the
+ `encrypted-by-id` fields of KMS-wrapped KEK entries in
`encryption-keys`. References to
+ table-internal keys are not KMS key IDs and must not be used for
credential matching.
Review Comment:
Agreed, dropping this part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
