slachiewicz opened a new pull request, #18779: URL: https://github.com/apache/iceberg/pull/18779
`TestFindFiles#testAsOfTimestamp` reads `System.currentTimeMillis()` right after committing `FILE_B` and then commits `FILE_C`. When `FILE_C`'s snapshot lands in the same millisecond, `asOfTime` includes it and the assertion fails with `data-c.parquet` in the result, as in [this core-tests run](https://github.com/apache/iceberg/actions/runs/41683484101/job/126082964627) on #18778, an unrelated change. This takes the timestamp with `TestHelpers.waitUntilAfter` once `FILE_B`'s snapshot time has passed, and waits past it again before committing `FILE_C`, so the timestamp is strictly between the two snapshots. Other core tests such as `TestSnapshotUtil` use the same helper. Test plan: `:iceberg-core:test --tests org.apache.iceberg.TestFindFiles` passes three times in a row on JDK 21 (44 tests); checkstyle and spotless pass. --- **AI Disclosure** - Model: [unknown - human to fill in] - Platform/Tool: Claude Code - Human Oversight: [unknown - human to fill in] - Prompt Summary: Fix the flaky TestFindFiles#testAsOfTimestamp seen in CI, verify locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
