gerashegalov commented on code in PR #18779:
URL: https://github.com/apache/iceberg/pull/18779#discussion_r4460096656
##########
core/src/test/java/org/apache/iceberg/TestFindFiles.java:
##########
@@ -138,7 +138,10 @@ public void testAsOfTimestamp() {
table.newAppend().appendFile(FILE_B).commit();
- long timestamp = System.currentTimeMillis();
+ // Strictly between FILE_B's and FILE_C's snapshots: in the same
millisecond as either, asOfTime
+ // would include FILE_C or drop FILE_B.
+ long timestamp =
TestHelpers.waitUntilAfter(table.currentSnapshot().timestampMillis());
+ TestHelpers.waitUntilAfter(timestamp);
Review Comment:
Could use one-wait pattern
```suggestion
long timestamp = table.currentSnapshot().timestampMillis();
TestHelpers.waitUntilAfter(timestamp);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
