blackmwk commented on code in PR #2916:
URL: https://github.com/apache/iceberg-rust/pull/2916#discussion_r4453129711
##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -106,6 +109,7 @@ pub(crate) mod _serde {
Double(f64),
String(String),
Bytes(ByteBuf),
+ Uuid(#[serde(serialize_with = "apache_avro::serde::fixed::serialize")]
[u8; 16]),
Review Comment:
I don't think we should add this, `RawLiteralEnum` is designed mainly for
physical types, so I think mapping uuid to bytes would be enough.
##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -473,8 +480,20 @@ pub(crate) mod _serde {
},
RawLiteralEnum::String(v) => match ty {
Type::Primitive(PrimitiveType::String) =>
Ok(Some(Literal::string(v))),
+ Type::Primitive(PrimitiveType::Uuid) =>
Hyphenated::from_str(&v)
Review Comment:
No, I think this should only handle bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
