JosephLenton commented on code in PR #2916:
URL: https://github.com/apache/iceberg-rust/pull/2916#discussion_r4474483440
##########
crates/iceberg/src/spec/values/serde.rs:
##########
@@ -473,8 +480,20 @@ pub(crate) mod _serde {
},
RawLiteralEnum::String(v) => match ty {
Type::Primitive(PrimitiveType::String) =>
Ok(Some(Literal::string(v))),
+ Type::Primitive(PrimitiveType::Uuid) =>
Hyphenated::from_str(&v)
Review Comment:
@blackmwk this is needed to handle deserialisation from Avro manifests where
the UUID is a String.
This is covered by the tests:
* `test_avro_should_convert_uuid_as_uuid` located here
https://github.com/apache/iceberg-rust/pull/2916/changes#diff-95afb7dd393f71a7be83cf1f3cd85646099245a8bee07c860ee8c50216db582cR1192
,
* and previously there was a datafusion-iceberg integration tests in this
repo which showed this behaviour. Now I have the same test here (which I'll
open to be merged when this is done):
https://github.com/JosephLenton/datafusion-iceberg/commit/cb4aa25635b0dfd27a08dab1a290df3b3f2538ca#diff-f5d1a6793b0651f158f734b21a1bd0e001654916fbd1886f1ab474784e1282e0R920
I'll take a look deeper though to see if it can be dropped.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
