anoopj commented on code in PR #18725:
URL: https://github.com/apache/iceberg/pull/18725#discussion_r4444173681
##########
core/src/main/java/org/apache/iceberg/FilePlanner.java:
##########
@@ -192,6 +196,10 @@ private TaskContext newTaskContext(int specId) {
ResidualEvaluator.of(spec, filter, caseSensitive));
}
+ private static boolean hasLiveFiles(ManifestFile leaf) {
+ return leaf.hasAddedFiles() || leaf.hasExistingFiles() ||
leaf.modifiedFilesCount() > 0;
Review Comment:
Tightened it to be null-safe, but with null equality meaning keep rather
than prune. Since pruning is an optimization, and an unknown count shouldn't be
able to drop a leaf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
