anoopj commented on code in PR #18725:
URL: https://github.com/apache/iceberg/pull/18725#discussion_r4445195617
##########
core/src/main/java/org/apache/iceberg/FilePlanner.java:
##########
@@ -192,6 +196,13 @@ private TaskContext newTaskContext(int specId) {
ResidualEvaluator.of(spec, filter, caseSensitive));
}
+ private static boolean hasLiveFiles(ManifestFile leaf) {
+ return leaf.hasAddedFiles()
+ || leaf.hasExistingFiles()
+ || leaf.modifiedFilesCount() == null
Review Comment:
That is a great point. Yes, I think it is safe to make that assumption. I
will update the check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
