nastra commented on code in PR #17523:
URL: https://github.com/apache/iceberg/pull/17523#discussion_r4457802597
##########
core/src/main/java/org/apache/iceberg/RewriteTablePathUtil.java:
##########
@@ -241,8 +241,8 @@ private static List<Snapshot> updatePathInSnapshots(
TableMetadata metadata, String sourcePrefix, String targetPrefix) {
List<Snapshot> newSnapshots =
Lists.newArrayListWithCapacity(metadata.snapshots().size());
for (Snapshot snapshot : metadata.snapshots()) {
- String newManifestListLocation =
Review Comment:
there are a few more places in this class that reference
snapshot.manifestListLocation() directly, should we update those as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
