stevenzwu commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r566342579
##########
File path: flink/src/test/java/org/apache/iceberg/flink/TestHelpers.java
##########
@@ -62,9 +61,8 @@ private TestHelpers() {
}
public static RowData copyRowData(RowData from, RowType rowType) {
- ExecutionConfig config = new ExecutionConfig();
TypeSerializer[] fieldSerializers = rowType.getChildren().stream()
- .map((LogicalType type) -> InternalSerializers.create(type, config))
+ .map((LogicalType type) -> InternalSerializers.create(type))
Review comment:
It will be great if we can achieve the goal. Looking at the behavior of
clone, I am wondering if we will need to reinvent a lot of specific serializers
(like `BooleanSerializer`) that `InternalSerializers` eventually depends on.
Those type serializers are also internal just like `InternalSerializers`.
Ideally, it will be great if `RowData` interface provides a public `clone`
API. Actually, in the FLIP-27 source, we need need to clone `RowData` since
RowDataIterator returns a reused `RowData` object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
