stevenzwu commented on a change in pull request #1956: URL: https://github.com/apache/iceberg/pull/1956#discussion_r568285911
########## File path: flink/src/test/java/org/apache/iceberg/flink/MiniClusterBase.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.flink; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.CoreOptions; +import org.apache.flink.runtime.testutils.MiniClusterResourceConfiguration; +import org.apache.flink.test.util.MiniClusterWithClientResource; +import org.apache.flink.test.util.TestBaseUtils; +import org.junit.ClassRule; +import org.junit.rules.TemporaryFolder; + +/** + * It will start a mini cluster with classloader.check-leaked-classloader=false, so that we won't break the unit tests + * because of the class loader leak issue. In our iceberg integration tests, there're some that will assert the results + * after finished the flink jobs, so actually we may access the class loader that has been closed by the flink task + * managers if we enable the switch classloader.check-leaked-classloader by default. + */ +public class MiniClusterBase extends TestBaseUtils { + + private static final int DEFAULT_PARALLELISM = 4; + + public static final Configuration CONFIG = new Configuration() + // disable classloader check as Avro may cache class/object in the serializers. + .set(CoreOptions.CHECK_LEAKED_CLASSLOADER, false); + + @ClassRule + public static MiniClusterWithClientResource miniClusterResource = new MiniClusterWithClientResource( Review comment: That is a great idea. will update ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
