hcrosse commented on code in PR #2354:
URL: https://github.com/apache/iceberg-go/pull/2354#discussion_r4492754031
##########
table/commit.go:
##########
@@ -87,6 +88,7 @@ func (t *Transaction) TableCommit() (TableCommit, error) {
// their updates stage no ref requirement. The helper returns a fresh
// slice, so appending here cannot touch t.reqs.
reqs := append(transactionRequirements(t.reqs, t.branch,
t.tbl.metadata), AssertTableUUID(meta.uuid))
+ reqs = append(reqs, expirationAssertions(t.tbl.metadata,
cmp.Or(t.branch, MainBranch), stagedWalkedRefs(t.expirations), reqs)...)
Review Comment:
Your reading is right. I added
`TestExpirationAssertionsSkipCreatedCommitBranch` for a branch transaction that
creates its branch and calls `ExpireSnapshots`. It checks that expiry walks the
new branch and that `TableCommit` has exactly three requirements: the branch's
single absence assertion, the table UUID assertion and an assertion on `main`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
