badalprasadsingh commented on code in PR #2454:
URL: https://github.com/apache/iceberg-go/pull/2454#discussion_r4496283125
##########
catalog/rest/rest.go:
##########
@@ -2750,7 +2750,7 @@ func (r *Catalog) RenameView(ctx context.Context, from,
to table.Identifier) (*v
map[int]error{
http.StatusNotFound: catalog.ErrNoSuchView,
http.StatusConflict: catalog.ErrViewAlreadyExists,
- }, allowNoContent())
+ }, allowNoContent(),
withErrorTypeOverride(map[string]error{errTypeNoSuchNamespace:
catalog.ErrNoSuchNamespace}))
Review Comment:
nit (non-blocking): RenameTable explains why its 404 is split bt `error.type`
a short note here would would be great to readers why only rename does this:
not LoadView or DropView
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
