jx2lee opened a new pull request, #2454:
URL: https://github.com/apache/iceberg-go/pull/2454
## Descriptions
#2173 split the rename 404 for tables by `error.type`, so a missing
destination namespace returns `ErrNoSuchNamespace` instead of `ErrNoSuchTable`.
`RenameView` has the same 404 semantics in the REST spec but still mapped every
404 to `ErrNoSuchView`.
Apply same `withErrorTypeOverride` to `RenameView`. untyped 404 still fails
back to `ErrNoSuchView`
## Testing
`TestRenameView404MissingNamespace` fails on main and passes with this
change. The existing `TestRenameView404` (typed `NoSuchViewException`) still
passes.
```
❯ go test -count=1 -run 'TestRestCatalog/TestRenameView' -v ./catalog/rest/
=== RUN TestRestCatalog
=== RUN TestRestCatalog/TestRenameView204
=== RUN TestRestCatalog/TestRenameView404
=== RUN TestRestCatalog/TestRenameView404MissingNamespace
=== RUN TestRestCatalog/TestRenameView409
--- PASS: TestRestCatalog (0.01s)
--- PASS: TestRestCatalog/TestRenameView204 (0.00s)
--- PASS: TestRestCatalog/TestRenameView404 (0.00s)
--- PASS: TestRestCatalog/TestRenameView404MissingNamespace (0.00s)
--- PASS: TestRestCatalog/TestRenameView409 (0.00s)
PASS
ok github.com/apache/iceberg-go/catalog/rest 0.962s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
