adiranjan25 commented on issue #18723: URL: https://github.com/apache/iceberg/issues/18723#issuecomment-6702479127
Hi @Rishavbhattarai, Thanks for the clarification and for highlighting the concern around preserving the ordering of stored bounds. I agree that a global change to `Comparators` could introduce unintended behavior. In the meantime, I have submitted a proposed fix in PR #18813: https://github.com/apache/iceberg/pull/18813 The implementation introduces a predicate-specific comparison helper to handle signed-zero equivalence without modifying the existing ordering of stored bounds. It also includes regression tests covering row evaluation, equality and set predicates, and metrics/manifest pruning. The PR is open for maintainer feedback, particularly on whether this is the preferred abstraction layer. I'd appreciate your review and technical feedback on the approach. Hopefully, we can collaborate on refining the existing PR rather than duplicating the implementation. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
