blackmwk commented on code in PR #3283:
URL: https://github.com/apache/iceberg-rust/pull/3283#discussion_r4511285328
##########
crates/iceberg/src/encryption/io.rs:
##########
@@ -74,8 +74,16 @@ impl EncryptedInputFile {
/// Creates a reader that transparently decrypts on each read.
pub async fn reader(&self) -> Result<Box<dyn FileRead>> {
- let encrypted_length = self.encrypted_length()?;
let raw_reader = self.inner.reader().await?;
+ self.decrypt_reader(raw_reader)
+ }
+
+ /// Wraps a transparently decrypting reader over the given `raw_reader`
+ pub(crate) fn decrypt_reader(
Review Comment:
I perfer the original wrap version, e.g. providing a transform function.
This ensures that the file is correctly deciphering the right file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
