kumarpritam863 commented on code in PR #18739:
URL: https://github.com/apache/iceberg/pull/18739#discussion_r4520123752
##########
flink/v2.3/flink/src/test/java/org/apache/iceberg/flink/sink/dynamic/TestDynamicRecordProcessor.java:
##########
@@ -172,7 +172,8 @@ private static DynamicRecordProcessor<DynamicRecord>
processorWithoutImmediateUp
String.valueOf(CACHE_REFRESH_MS)),
new Configuration()),
Collections.emptyMap(),
- new Configuration());
+ new Configuration(),
+ null);
Review Comment:
Added harness tests: a diverted failure (conversion, same schema, forward
record, missing equality field), a propagated failure (the filter rejects it,
and no error stream), rows that only delete, a failing generator (not
diverted), and failures of operators chained to the forward and the main
output. The upsert checks against an older spec of the table are covered as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
