gaborkaszab commented on code in PR #18486: URL: https://github.com/apache/iceberg/pull/18486#discussion_r4530084366
########## api/src/main/java/org/apache/iceberg/HasReferencedFiles.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +/** An object that references content files. */ +public interface HasReferencedFiles { Review Comment: Taking a step back, here is my motivation for the refactor: I found that in terms of encryption support, our readers are asymmetric now, e.g. Spark readers can read encrypted data and deletes files, but `GenericReader` and `IcebergInputFormat` can't read encrypted delete files, while `EqualityConvertReader` can't read neither encrypted data nor delete files. The idea is to wire-in `InputFilesDecryptor` into the readers where we get it guaranteed that given a `ScanTask` by the reader we have all the referenced files involved with decryption, eliminating asymmetry. Other motivation is that whenever we add new set of files, e.g. ColumnFiles into the picture, we don't forget to implement encryption support for them. Doing that in `InputFilesDecryptor` solves this too. The above proposal makes `referencedFiles` in Spark redundant with what `InputFilesDecryptor` is meant to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
