mkroll-db commented on code in PR #3309:
URL: https://github.com/apache/iceberg-rust/pull/3309#discussion_r4530812086
##########
crates/catalog/glue/src/catalog.rs:
##########
@@ -897,6 +897,13 @@ impl Catalog for GlueCatalog {
Ok(builder.build()?)
}
+ async fn unregister_table(&self, _table_ident: &TableIdent) ->
Result<Table> {
Review Comment:
I implemented `unregister` in glue now. However, I want to point out that
it's not thread safe. Glue in general doesn't seem to be thread safe, see
`rename`.
Regarding "yet" this is used in other places too. I'd rather keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
