mkroll-db commented on code in PR #3309:
URL: https://github.com/apache/iceberg-rust/pull/3309#discussion_r4530842385
##########
crates/iceberg/src/catalog/mod.rs:
##########
@@ -121,6 +121,12 @@ pub trait Catalog: Debug + Sync + Send {
/// Register an existing table to the catalog.
async fn register_table(&self, table: &TableIdent, metadata_location:
String) -> Result<Table>;
+ /// Unregister a table without deleting its data or metadata files.
+ ///
+ /// The returned table contains the last committed metadata and its
location,
+ /// which can be passed to [`Catalog::register_table`] to register it
again.
+ async fn unregister_table(&self, table: &TableIdent) -> Result<Table>;
Review Comment:
Another example `KeyManagementClient::generate_key` is optional (gated by
`supports_key_generation()`) but still required, and the in-memory KMS returns
`FeatureUnsupported`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
