rdblue commented on a change in pull request #2089:
URL: https://github.com/apache/iceberg/pull/2089#discussion_r567146441
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -371,6 +374,10 @@ public PartitionSpec spec(int id) {
return specsById;
}
+ int lastAssignedFieldId() {
Review comment:
I think this name is potentially confusing. It is the last assigned
partition field ID, and "partition" is a key part of it. How about renaming it
to `lastAssignedPartitionId` instead?
##########
File path: core/src/main/java/org/apache/iceberg/TableMetadata.java
##########
@@ -371,6 +374,10 @@ public PartitionSpec spec(int id) {
return specsById;
}
+ int lastAssignedFieldId() {
Review comment:
I think this name is potentially confusing. It is the last assigned
partition field ID, and "partition" is a key part of it. How about renaming it
to `lastAssignedPartitionId` instead? Same with the instance field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
