rdblue commented on pull request #2089: URL: https://github.com/apache/iceberg/pull/2089#issuecomment-770110233
Thank you, @jun-he! I think there are few main improvements needed: 1. We should use `lastAssignedPartitionId` instead of `lastAssignedFieldId` in all cases to be more specific 2. For a table replace, we need to reassign the partition field IDs and reuse any existing IDs for equivalent fields 3. We need to update the spec doc We can do all 3 in this PR, or just the first one if you prefer to separate them. Just let me know. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
