rdblue commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r567173516
##########
File path: api/src/test/java/org/apache/iceberg/expressions/TestEvaluator.java
##########
@@ -220,6 +222,24 @@ public void testNotEqual() {
}
+ @Test
+ public void testStartsWith() {
+ StructType struct = StructType.of(required(24, "s",
Types.StringType.get()));
+ Evaluator evaluator = new Evaluator(struct, startsWith("s", "abc"));
+ Assert.assertTrue("abc startsWith abc => true",
evaluator.eval(TestHelpers.Row.of("abc")));
Review comment:
Usually, the expectation in context is given with "should". That way,
when it fails the message is "abc startsWith abc should be true". It's easy to
read and understand the problem that way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
