RussellSpitzer commented on code in PR #18252:
URL: https://github.com/apache/iceberg/pull/18252#discussion_r4540953292
##########
api/src/main/java/org/apache/iceberg/types/TypeUtil.java:
##########
@@ -753,6 +817,15 @@ public T variant(Types.VariantType variant) {
throw new UnsupportedOperationException("Unsupported type: variant");
}
+ /**
+ * Handles a file type, by default as the struct of its nested fields.
+ *
+ * <p>Override this to distinguish a file from a struct.
Review Comment:
I don't think it is practically wrong to treat it as a struct for almost all
visitors so that's why I wanted the default here. I don't mind just putting it
in explicitly everywhere though. Let me make the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
